langchain[minor]: Add pgvector to list of supported vectorstores in self query retriever #22678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
size:XS
eyurtsev
approved these changes
Jun 10, 2024
dosubot
bot
added
the
lgtm
eyurtsev
approved these changes
Jun 10, 2024
| @@ -168,6 +168,14 @@ def _get_builtin_translator(vectorstore: VectorStore) -> Visitor: | |||
| if isinstance(vectorstore, Chroma): | |||
| return ChromaTranslator() | |||
|
|
|||
| try: | |||
| from langchain_postgres import PGVector | |||
There was a problem hiding this comment.
(not related to your PR) The try and except here is very odd -- we can just pull the package name from the vectorstore instance itself (via .class)
eyurtsev
changed the title
pprados
added a commit
to pprados/langchain
that referenced
this pull request
Jun 11, 2024
…elf query retriever (langchain-ai#22678) The fact that we outsourced pgvector to another project has an unintended effect. The mapping dictionary found by `_get_builtin_translator()` cannot recognize the new version of pgvector because it comes from another package. `SelfQueryRetriever` no longer knows `PGVector`. I propose to fix this by creating a global dictionary that can be populated by various database implementations. Thus, importing `langchain_postgres` will allow the registration of the `PGvector` mapping. But for the moment I'm just adding a lazy import Furthermore, the implementation of _get_builtin_translator() reconstructs the BUILTIN_TRANSLATORS variable with each invocation, which is not very efficient. A global map would be an optimization. - **Twitter handle:** pprados @eyurtsev, can you review this PR? And unlock the PR [Add async mode for pgvector](langchain-ai/langchain-postgres#32) and PR [community[minor]: Add SQL storage implementation](langchain-ai#22207)? Are you in favour of a global dictionary-based implementation of Translator?
hinthornw
pushed a commit
that referenced
this pull request
Jun 20, 2024
…elf query retriever (#22678) The fact that we outsourced pgvector to another project has an unintended effect. The mapping dictionary found by `_get_builtin_translator()` cannot recognize the new version of pgvector because it comes from another package. `SelfQueryRetriever` no longer knows `PGVector`. I propose to fix this by creating a global dictionary that can be populated by various database implementations. Thus, importing `langchain_postgres` will allow the registration of the `PGvector` mapping. But for the moment I'm just adding a lazy import Furthermore, the implementation of _get_builtin_translator() reconstructs the BUILTIN_TRANSLATORS variable with each invocation, which is not very efficient. A global map would be an optimization. - **Twitter handle:** pprados @eyurtsev, can you review this PR? And unlock the PR [Add async mode for pgvector](langchain-ai/langchain-postgres#32) and PR [community[minor]: Add SQL storage implementation](#22207)? Are you in favour of a global dictionary-based implementation of Translator?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to LangChain!
langchain: "package: description"
PR message:
Description:
The fact that we outsourced pgvector to another project has an unintended effect. The mapping dictionary found by
_get_builtin_translator()cannot recognize the new version of pgvector because it comes from another package.SelfQueryRetrieverno longer knowsPGVector.I propose to fix this by creating a global dictionary that can be populated by various database implementations. Thus, importing
langchain_postgreswill allow the registration of thePGvectormapping.But for the moment I'm just adding a lazy import
Furthermore, the implementation of _get_builtin_translator() reconstructs the BUILTIN_TRANSLATORS variable with each invocation, which is not very efficient. A global map would be an optimization.
@eyurtsev, can you review this PR? And unlock the PR Add async mode for pgvector and PR community[minor]: Add SQL storage implementation?
Are you in favour of a global dictionary-based implementation of Translator?