Skip to content

community: Add support for '$not' operator in PGVector #22423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

community: Add support for '$not' operator in PGVector #22423

wants to merge 2 commits into from

Conversation

Raj725
Copy link
Contributor

@Raj725 Raj725 commented Jun 3, 2024

  • Description: Add support for '$not' operator in PGVector
  • Issue: NA
  • Dependencies: NO
  • Twitter handle: @Raj__725
  • Add tests and docs: NA (Not adding a new integration)

@vercel Vercel
Copy link

vercel bot commented Jun 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jun 3, 2024 0:13am

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. Ɑ: vector store Related to vector store module 🤖:improvement Medium size change to existing code to handle new use-cases labels Jun 3, 2024
baskaryan
baskaryan reviewed Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@baskaryan baskaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this implementation is deprecated, the maintained version of this integration lives in https://github.com/langchain-ai/langchain-postgres repo — could we open this PR there

@Raj725
Copy link
Contributor Author

Raj725 commented Jun 4, 2024

this implementation is deprecated, the maintained version of this integration lives in https://github.com/langchain-ai/langchain-postgres repo — could we open this PR there

@baskaryan I've opened a PR in the new repo. Please take a look and review it there. Thanks!

eyurtsev
eyurtsev reviewed Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@eyurtsev eyurtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a unit test?

FWIW this vectorstore has been moved to langchain-postgres

https://github.com/langchain-ai/langchain-postgres

@Raj725
Copy link
Contributor Author

Raj725 commented Jun 7, 2024

Could you add a unit test?

FWIW this vectorstore has been moved to langchain-postgres

https://github.com/langchain-ai/langchain-postgres

Sure, I'll add the unit test. I have also raised a PR to the new repo.

@ccurme ccurme added the community Related to langchain-community label Jun 18, 2024
@Raj725 Raj725 closed this Jun 24, 2024
@Raj725
Copy link
Contributor Author

Raj725 commented Jun 24, 2024

Closed since langchain-ai/langchain-postgres#62 got merged

@Raj725 Raj725 deleted the pgvector_not_operator branch June 24, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyurtsev eyurtsev eyurtsev left review comments

@baskaryan baskaryan baskaryan left review comments

Assignees
No one assigned
Labels
community Related to langchain-community 🤖:improvement Medium size change to existing code to handle new use-cases size:S This PR changes 10-29 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Raj725 @eyurtsev @baskaryan @ccurme