-
Notifications
You must be signed in to change notification settings - Fork 17.9k
community[minor]: Add native async support to SQLChatMessageHistory #22065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eyurtsev
merged 40 commits into
langchain-ai:master
from
pprados:pprados/fix_sql_chat_history
Jun 5, 2024
Merged
Changes from 39 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
31dc9c0
Real async version of SQLChatMessageHistory
pprados 1eea86d
Fix spelling
pprados a19ca59
Fix spelling
pprados 6a7a1b0
Merge branch 'master' into pprados/fix_sql_chat_history
pprados bab80a6
Fix dependencies
pprados 8dfe16d
Fix revue
pprados 35b7068
Fix poetry
pprados 2e008a1
Merge branch 'master' into pprados/fix_sql_chat_history
pprados 862ebcb
Fix format
pprados a2e5d3f
Merge remote-tracking branch 'origin/pprados/fix_sql_chat_history' in…
pprados df1f50a
Fix format
pprados 9126f8c
Fix format
pprados ba28b80
Merge branch 'master' into pprados/fix_sql_chat_history
pprados 17245b5
Merge branch 'master' into pprados/fix_sql_chat_history
pprados 601a480
Merge branch 'master' into pprados/fix_sql_chat_history
pprados 3a51c8e
Add @deprecated
pprados bd47d2f
Merge remote-tracking branch 'origin/pprados/fix_sql_chat_history' in…
pprados 44ddc44
Fix @deprecated
pprados 769608d
Fix @deprecated
pprados f74496d
Fix format
pprados 14a4bc8
Fix format
pprados e858162
Merge branch 'master' into pprados/fix_sql_chat_history
pprados 731c82f
Only once warning
pprados 1391f54
Merge remote-tracking branch 'origin/pprados/fix_sql_chat_history' in…
pprados 75bc80e
Merge branch 'master' into pprados/fix_sql_chat_history
pprados 53a6abd
Only once warning
pprados 39a983a
Merge remote-tracking branch 'origin/pprados/fix_sql_chat_history' in…
pprados 6f1e932
Only once warning
pprados 8f3c6a1
Warning when create session
pprados bb345ba
Warning when create session
pprados b6591ae
Fix typing
pprados 31b6c56
Remove duplicate assertion
pprados 1df1620
Fix base
pprados fafc598
Add get_messages()
pprados fc98107
Merge branch 'master' into pprados/fix_sql_chat_history
pprados 4d153f5
Merge branch 'master' into pprados/fix_sql_chat_history
pprados 95a097e
Merge branch 'master' into pprados/fix_sql_chat_history
eyurtsev f991c99
x
eyurtsev df1d62e
Revert changes to test dependencies. aiosqlite should be optional
eyurtsev 68df505
relock
eyurtsev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -291,6 +291,7 @@ extended_testing = [ | |
"pyjwt", | ||
"oracledb", | ||
"simsimd", | ||
"aiosqlite" | ||
] | ||
|
||
[tool.ruff] | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(unrelated to this PR)
@pprados this pattern could be useful if you needed a transaction (e.g., as was the case in the indexing API if I recall correctly)
Allows passing a session maker as part of the init instead of initializing and then mutating a class attribute (the latter pattern is more likely to break in threaded scenarios)