Fixed support for VectorStore search filters with multiple $like/$ilike/$in/$nin on same column #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
averikitsch
reviewed
Jun 13, 2025
| @@ -303,7 +303,8 @@ async def aadd_embeddings( | |||
| values_stmt = "VALUES (:langchain_id, :content, :embedding" | |||
|
|
|||
| if not embedding and can_inline_embed: | |||
| values_stmt = f"VALUES (:langchain_id, :content, {self.embedding_service.embed_query_inline(content)}" # type: ignore | |||
| # type: ignore | |||
There was a problem hiding this comment.
Can you move the comment back to the original location in order for the lint to pass?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #216.
Pull request adds a filter test case that was failing and the fix for internal function _handle_field_filter.
The function fix is to add an unique identifier to the column names of operator in, nin, like and ilike