feat: Adding PGChatMessageHistory #203
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Add PGChatMessageHistory
chore(docs): Add documentation for PGChatMessageHistory
averikitsch
reviewed
Apr 29, 2025
| else: | ||
| return f"""SELECT data, type FROM "{self.schema_name}"."{self.table_name}" WHERE session_id = :session_id ORDER BY id;""" | ||
|
|
||
| def _convert_to_messages(self, rows: Sequence[RowMapping]) -> list[BaseMessage]: |
There was a problem hiding this comment.
I've left some functions to be semi private so we can override them in the google integrations. These are mostly related to how the data is to be pulled from the db or added in depending on the schema
averikitsch
approved these changes
May 6, 2025
eyurtsev
reviewed
Jun 9, 2025
| session_id: str, | ||
| table_name: str, | ||
| store_message: bool, | ||
| schema_name: str = "public", |
There was a problem hiding this comment.
Linting:
- Use a boolean trap (h)ttps://docs.astral.sh/ruff/rules/boolean-type-hint-positional-argument/
- schema_name takes a default, so put it after a
*operator
| self, | ||
| key: object, | ||
| pool: AsyncEngine, | ||
| session_id: str, |
There was a problem hiding this comment.
Could you sanitize the table name and schema name? It looks like it's possible to inject SQL
| await conn.execute(text(create_table_query)) | ||
| await conn.commit() | ||
|
|
||
| async def ainit_chat_history_table( |
There was a problem hiding this comment.
The engine abstraction is coupling vectorstores and chat history which are two completely different things.
Missing a compositional pattern and an admin layer for chat history + vectorstors to be able to create / drop tables
|
Looks pretty good overall! A few comments:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Adding PGChatMessageHistory along with it's documentation
Not deprecating the PostgresChatMessageHistory for now (as the deprcation for PGVector has been removed).