Skip to content

[langchain-db/feat]: Added support for text_field #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 9, 2025
Merged

[langchain-db/feat]: Added support for text_field #118

merged 4 commits into from
Oct 9, 2025

Conversation

MateuszOssGit
Copy link
Collaborator

Added support for text_field param in DB2VS class

DB2VS(
  embedding_function=model,
  table_name=table_name,
  client=connection,
  text_field="text_v2",
)

Mateusz-Switala
Mateusz-Switala approved these changes Oct 9, 2025
View reviewed changes
Copy link
Collaborator

@Mateusz-Switala Mateusz-Switala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MateuszOssGit
Copy link
Collaborator Author

Local integration test results:

Screenshot 2025-10-09 at 10 54 10

@MateuszOssGit MateuszOssGit merged commit 9bf5165 into main Oct 9, 2025
15 checks passed
@MateuszOssGit MateuszOssGit deleted the dev-added-text_field branch October 9, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wojciech-Rebisz Wojciech-Rebisz Wojciech-Rebisz approved these changes

@Mateusz-Switala Mateusz-Switala Mateusz-Switala approved these changes

@yiweiHeOSS yiweiHeOSS Awaiting requested review from yiweiHeOSS

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MateuszOssGit @Wojciech-Rebisz @Mateusz-Switala