Skip to content

feat: support overriding CSP & using nonce #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 7, 2025
Merged

feat: support overriding CSP & using nonce #470

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5991a81
feat: support overriding CSP & using nonce
bvs-langchain Oct 2, 2025
c389fe0
readme, chart version
bvs-langchain Oct 2, 2025
48a9aed
fix merge conflict
bvs-langchain Oct 7, 2025
af77fc3
version bump
bvs-langchain Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/langsmith/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ maintainers:
email: ankush@langchain.dev
description: Helm chart to deploy the langsmith application and all services it depends on.
type: application
version: 0.11.20
version: 0.11.21
appVersion: "0.11.57"
4 changes: 3 additions & 1 deletion charts/langsmith/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,6 +557,7 @@ For information on how to use this chart, up-to-date release notes, and other gu
| frontend.autoscaling.targetCPUUtilizationPercentage | int | `50` | |
| frontend.autoscaling.targetMemoryUtilizationPercentage | int | `80` | |
| frontend.containerPort | int | `8080` | |
| frontend.cspHeader | string | `"frame-ancestors 'self'; object-src 'none'"` | |
| frontend.deployment.affinity | object | `{}` | |
| frontend.deployment.annotations | object | `{}` | |
| frontend.deployment.command[0] | string | `"/entrypoint.sh"` | |
Expand Down Expand Up @@ -594,6 +595,7 @@ For information on how to use this chart, up-to-date release notes, and other gu
| frontend.deployment.volumeMounts | list | `[]` | |
| frontend.deployment.volumes | list | `[]` | |
| frontend.existingConfigMapName | string | `""` | |
| frontend.includeNonce | bool | `false` | |
| frontend.ipv6Enabled | bool | `true` | |
| frontend.keepAliveTimeout | string | `"75"` | |
| frontend.maxBodySize | string | `"25M"` | |
Expand Down Expand Up @@ -1066,6 +1068,6 @@ For information on how to use this chart, up-to-date release notes, and other gu
| Ankush | <ankush@langchain.dev> | |

----------------------------------------------
Autogenerated from chart metadata using [helm-docs v1.14.2](https://github.com/norwoodj/helm-docs/releases/v1.14.2)
Autogenerated from chart metadata using [helm-docs v1.13.1](https://github.com/norwoodj/helm-docs/releases/v1.13.1)
## Docs Generated by [helm-docs](https://github.com/norwoodj/helm-docs)
`helm-docs -t ./charts/langsmith/README.md.gotmpl`
16 changes: 14 additions & 2 deletions charts/langsmith/templates/frontend/config-map.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ data:
proxy_send_timeout {{ .Values.frontend.proxyWriteTimeout }};
keepalive_timeout {{ .Values.frontend.keepAliveTimeout }};

add_header Content-Security-Policy "frame-ancestors 'self'; object-src 'none'" always;
add_header Content-Security-Policy "{{ .Values.frontend.cspHeader }}" always;
add_header X-Frame-Options "SAMEORIGIN" always;
add_header X-Content-Type-Options "nosniff" always;
add_header Strict-Transport-Security "max-age=31536000; includeSubDomains; preload" always;
Expand Down Expand Up @@ -411,18 +411,30 @@ data:
proxy_send_timeout {{ .Values.frontend.proxyWriteTimeout }};
keepalive_timeout {{ .Values.frontend.keepAliveTimeout }};

add_header Content-Security-Policy "frame-ancestors 'self'; object-src 'none'" always;
add_header Content-Security-Policy "{{ .Values.frontend.cspHeader }}" always;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does user have to set:

"script-src 'nonce-$request_id' 'strict-dynamic'; style-src 'nonce-$request_id' 'strict-dynamic';" always;

themselves?

Copy link
Contributor Author

@bvs-langchain bvs-langchain Oct 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we could pass through the LangSmith domain and avoid this config option, but I think slightly preferred to have the flexibility, at least while this is under development

add_header X-Frame-Options "SAMEORIGIN" always;
add_header X-Content-Type-Options "nosniff" always;
add_header Strict-Transport-Security "max-age=31536000; includeSubDomains; preload" always;

access_log /var/log/nginx/access.log cache_log_json;

{{- if .Values.frontend.includeNonce }}
location / {
sub_filter_once off;
# Replace placeholder with nonce in HTML
sub_filter '%%NONCE%%' $request_id;

root /tmp/build;
index index.html index.htm;
try_files $uri $uri/ /index.html;
}
{{- else }}
location / {
root /tmp/build;
index index.html index.htm;
try_files $uri $uri/ /index.html;
}
{{- end }}

location = /health {
# health checks are frequent and boring, so we avoid logging them
Expand Down
5 changes: 5 additions & 0 deletions charts/langsmith/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,6 +662,11 @@ frontend:
existingConfigMapName: ""
# Nginx Max Body Size. Refer to https://nginx.org/en/docs/http/ngx_http_core_module.html#client_max_body_size for more information.
maxBodySize: "25M"
# Custom CSP Header. Refer to https://developer.mozilla.org/en-US/docs/Web/HTTP/Guides/CSP.
# If includeNonce is true, use nginx built-in $request_id as nonce (cryptographically secure because compiled with OpenSSL)
# Sample compatible CSP header with includeNonce: true: "script-src 'nonce-$request_id' 'strict-dynamic'; style-src 'nonce-$request_id' 'strict-dynamic'; frame-ancestors 'self'; object-src 'none'"
cspHeader: "frame-ancestors 'self'; object-src 'none'"
includeNonce: false
proxyReadTimeout: "300"
proxyWriteTimeout: "300"
proxyConnectTimeout: "60"
Expand Down