Skip to content

chore: filter K8s debugging script to LangChain resources only #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2025
Merged

chore: filter K8s debugging script to LangChain resources only #467

merged 2 commits into from
Oct 1, 2025

Conversation

nitboss
Copy link
Contributor

@nitboss nitboss commented Sep 30, 2025

Summary

  • Updates get_k8s_debugging_info.sh to filter results for only LangChain-related resources
  • Allows customers to embed other resources in the same cluster without polluting debug output
  • Removes jq dependency by using jsonpath for restart count check

Changes

  • Resource filtering: Added grep filters for langsmith-*, lg-*, and toolbox* prefixes to:
    • Resource summary output
    • Resource details YAML
    • Pod resource usage
    • Pod log collection
  • Simplified restart count check: Changed from jq to jsonpath for better portability
  • Improved output messages: Updated echo statements for clarity

Test Plan

  • Test script on namespace with mixed LangChain and non-LangChain resources
  • Verify only LangChain resources appear in output files
  • Test with pods that have restart counts > 0
  • Confirm no jq dependency required

chore: filter K8s debugging script to LangChain resources only
72897ac 
Updates get_k8s_debugging_info.sh to filter results for only LangChain-related
resources (langsmith-*, lg-*, toolbox*), allowing customers to embed other
resources in the same cluster without polluting debug output.

Changes:
- Filter resource summary, details, and pod usage to LangChain prefixes
- Filter pod log collection to only LangChain-related pods
- Simplify restart count check to remove jq dependency
- Update output messages for clarity
@nitboss nitboss enabled auto-merge (squash) September 30, 2025 21:43
langchain-infra
langchain-infra reviewed Sep 30, 2025
View reviewed changes
Copy link
Contributor

@langchain-infra langchain-infra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just add an option to this chart to filter by regex or label which is moer common in k8s? people deploy Ls under different names (e.g LG platform etc).

feat: add configurable filtering to K8s debugging script
746f23f 
- Add --filter-regex option for custom name pattern matching
- Add --filter-labels option for Kubernetes label selectors (recommended)
- Maintains backward compatibility with default regex filter
- Addresses PR feedback to support different deployment names (LG platform, etc.)

Examples:
  --filter-regex '^(lc-|langgraph-)'
  --filter-labels 'app.kubernetes.io/instance=lg-platform'
@nitboss
Copy link
Contributor Author

nitboss commented Oct 1, 2025

can we just add an option to this chart to filter by regex or label which is moer common in k8s? people deploy Ls under different names (e.g LG platform etc).

@langchain-infra Please review now

@nitboss nitboss merged commit b20ddd6 into main Oct 1, 2025
4 checks passed
@nitboss nitboss deleted the filter-k8s-debugging-langchain-resources branch October 1, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@langchain-infra langchain-infra langchain-infra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nitboss @langchain-infra