Skip to content

Add Storage Engine validation for Blob storage #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2025
Merged

Add Storage Engine validation for Blob storage #466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3dd5a6
add storage engine validation
romain-priour-lc Sep 30, 2025
a4950af
support lowercase s3 as well
romain-priour-lc Sep 30, 2025
c72d899
added lowercase azure as well
romain-priour-lc Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/langsmith/templates/NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{{- include "langsmith.validateTracing" . -}}
{{- include "langsmith.validateBlobStorage" . -}}
Thank you for installing LangSmith!

This is the LangSmith application helm chart. All pods should be running! You can access the LangSmith UI by running the following command:
Expand Down
17 changes: 15 additions & 2 deletions charts/langsmith/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ Template containing common environment variables that are used by several servic
value: {{ .Values.config.blobStorage.engine | quote }}
- name: MIN_BLOB_STORAGE_SIZE_KB
value: {{ ternary 0 .Values.config.blobStorage.minBlobStorageSizeKb .Values.clickhouse.external.hybrid | quote }}
{{- if eq .Values.config.blobStorage.engine "S3" }}
{{- if (or (eq .Values.config.blobStorage.engine "S3") (eq .Values.config.blobStorage.engine "s3")) }}
- name: S3_BUCKET_NAME
value: {{ .Values.config.blobStorage.bucketName | quote }}
- name: S3_RUN_MANIFEST_BUCKET_NAME
Expand All @@ -300,7 +300,7 @@ Template containing common environment variables that are used by several servic
key: blob_storage_access_key_secret
optional: true
{{- end }}
{{- if eq .Values.config.blobStorage.engine "Azure" }}
{{- if (or (eq .Values.config.blobStorage.engine "Azure") (eq .Values.config.blobStorage.engine "azure")) }}
- name: AZURE_STORAGE_ACCOUNT_NAME
value: {{ .Values.config.blobStorage.azureStorageAccountName | quote }}
- name: AZURE_STORAGE_CONTAINER_NAME
Expand Down Expand Up @@ -519,6 +519,19 @@ Validate tracing configuration
{{- end -}}
{{- end -}}

{{/*
Validate blob storage configuration
*/}}
{{- define "langsmith.validateBlobStorage" -}}
{{- if and .Values.config.blobStorage.enabled (not .Values.config.blobStorage.engine) -}}
{{- fail "When blob storage is enabled (config.blobStorage.enabled=true), config.blobStorage.engine must be one of [S3, Azure]" -}}
{{- end -}}
{{- if and .Values.config.blobStorage.enabled (not (or (eq .Values.config.blobStorage.engine "S3") (eq .Values.config.blobStorage.engine "s3") (eq .Values.config.blobStorage.engine "Azure") (eq .Values.config.blobStorage.engine "azure"))) -}}
{{- fail "When blob storage is enabled (config.blobStorage.enabled=true), config.blobStorage.engine must be one of [S3, Azure]" -}}
{{- end -}}
{{- end -}}


{{- define "langsmith.tlsVolumeMounts" -}}
{{- if and .Values.config.customCa.secretName .Values.config.customCa.secretKey -}}
- name: langsmith-custom-ca
Expand Down