-
Notifications
You must be signed in to change notification settings - Fork 120
docs(integration): Add and update integration files for langchain-hana (graphs, chains) #766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
user=os.environ.get("HANA_DB_USER"), | ||
password=os.environ.get("HANA_DB_PASSWORD"), | ||
autocommit=True, | ||
sslValidateCertificate=False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this False?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is up to the user to enable/disable this feature while establishing the connection. So it is not dependent upon the example.
user=os.environ.get("HANA_DB_USER"), | ||
password=os.environ.get("HANA_DB_PASSWORD"), | ||
autocommit=True, | ||
sslValidateCertificate=False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this safe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have removed this optional parameter from the example, upto the user to incorporate or not.
Description:
Added and updated files for langchain-hana python package demonstrating the hana knowledge graph engine HanaRdfGraph and HanaSparqlQAChain. Also updated the provider page /oss/integrations/providers/ to point to these new files.
Issue: N/A
Dependencies: N/A
Pypi - https://pypi.org/project/langchain-hana/
Repo - https://github.com/SAP/langchain-integration-for-sap-hana-cloud