Skip to content

Fix replay usage in blocks CI #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2025
Merged

Fix replay usage in blocks CI #1263

merged 3 commits into from
Jun 23, 2025

Conversation

FrancoGiachetta
Copy link
Contributor

@FrancoGiachetta FrancoGiachetta commented Jun 23, 2025

The last version of starknet-replay intoduces a series of binaries. Thus, we now need to specify which of them we are going to use. This wasn't updated in cairo native's ci, which caused its failure.
Also, updated the starknet-replay's and sequencer's version in starknet-blocks workflow so that they match the ones in the daily workflow.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link

Benchmarking results

Benchmark for program dict_insert

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.663 ± 0.071 11.580 11.829 2.30 ± 0.03
cairo-native (embedded AOT) 5.065 ± 0.060 4.963 5.150 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 5.101 ± 0.039 5.046 5.176 1.01 ± 0.01

Benchmark for program dict_snapshot

Open benchmarks
Command Mean [ms] Min [ms] Max [ms] Relative
Cairo-vm (Rust, Cairo 1) 841.2 ± 18.7 820.0 874.4 1.00
cairo-native (embedded AOT) 4980.0 ± 47.9 4909.4 5051.7 5.92 ± 0.14
cairo-native (embedded JIT using LLVM's ORC Engine) 5096.7 ± 57.2 5015.9 5192.6 6.06 ± 0.15

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.369 ± 0.044 5.310 5.473 1.00
cairo-native (embedded AOT) 5.516 ± 0.100 5.385 5.682 1.03 ± 0.02
cairo-native (embedded JIT using LLVM's ORC Engine) 5.604 ± 0.056 5.506 5.692 1.04 ± 0.01

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.128 ± 0.014 5.104 5.147 1.02 ± 0.02
cairo-native (embedded AOT) 5.175 ± 0.043 5.113 5.263 1.02 ± 0.02
cairo-native (embedded JIT using LLVM's ORC Engine) 5.052 ± 0.080 4.982 5.199 1.00

Benchmark for program linear_search

Open benchmarks
Command Mean [ms] Min [ms] Max [ms] Relative
Cairo-vm (Rust, Cairo 1) 861.6 ± 7.1 847.1 869.9 1.00
cairo-native (embedded AOT) 5094.5 ± 82.6 4975.2 5238.3 5.91 ± 0.11
cairo-native (embedded JIT using LLVM's ORC Engine) 5350.7 ± 40.6 5294.7 5401.1 6.21 ± 0.07

Benchmark for program logistic_map

Open benchmarks
Command Mean [ms] Min [ms] Max [ms] Relative
Cairo-vm (Rust, Cairo 1) 585.4 ± 6.4 576.0 594.9 1.00
cairo-native (embedded AOT) 5296.0 ± 55.5 5235.4 5413.5 9.05 ± 0.14
cairo-native (embedded JIT using LLVM's ORC Engine) 5511.4 ± 90.1 5338.1 5622.3 9.41 ± 0.19

Copy link

Benchmark results Main vs HEAD.

Base

Command Mean [s] Min [s] Max [s] Relative
base dict_insert.cairo (JIT) 5.110 ± 0.042 5.055 5.176 1.03 ± 0.01
base dict_insert.cairo (AOT) 4.985 ± 0.032 4.945 5.059 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head dict_insert.cairo (JIT) 5.719 ± 0.104 5.516 5.850 1.03 ± 0.03
head dict_insert.cairo (AOT) 5.541 ± 0.108 5.336 5.639 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base dict_snapshot.cairo (JIT) 5.009 ± 0.038 4.964 5.066 1.02 ± 0.02
base dict_snapshot.cairo (AOT) 4.887 ± 0.064 4.838 5.051 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head dict_snapshot.cairo (JIT) 5.491 ± 0.084 5.317 5.603 1.04 ± 0.03
head dict_snapshot.cairo (AOT) 5.300 ± 0.113 5.113 5.425 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 5.462 ± 0.086 5.333 5.558 1.00
base factorial_2M.cairo (AOT) 5.473 ± 0.048 5.377 5.536 1.00 ± 0.02

Head

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 5.633 ± 0.082 5.517 5.779 1.02 ± 0.02
head factorial_2M.cairo (AOT) 5.544 ± 0.051 5.470 5.635 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 4.900 ± 0.059 4.839 5.046 1.02 ± 0.01
base fib_2M.cairo (AOT) 4.811 ± 0.032 4.771 4.867 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 5.108 ± 0.066 5.006 5.246 1.02 ± 0.02
head fib_2M.cairo (AOT) 5.032 ± 0.051 4.945 5.104 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base linear_search.cairo (JIT) 5.106 ± 0.031 5.067 5.143 1.02 ± 0.02
base linear_search.cairo (AOT) 4.985 ± 0.068 4.897 5.152 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head linear_search.cairo (JIT) 5.313 ± 0.083 5.204 5.424 1.03 ± 0.03
head linear_search.cairo (AOT) 5.181 ± 0.124 5.030 5.418 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 5.140 ± 0.035 5.098 5.197 1.02 ± 0.01
base logistic_map.cairo (AOT) 5.048 ± 0.058 4.979 5.144 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 5.662 ± 0.170 5.371 5.932 1.07 ± 0.04
head logistic_map.cairo (AOT) 5.273 ± 0.133 5.115 5.566 1.00

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.21%. Comparing base (858681c) to head (4478643).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1263   +/-   ##
=======================================
  Coverage   80.21%   80.21%           
=======================================
  Files         112      112           
  Lines       29880    29880           
=======================================
  Hits        23967    23967           
  Misses       5913     5913           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@JulianGCalderon JulianGCalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrielbosio gabrielbosio added this pull request to the merge queue Jun 23, 2025
Merged via the queue into main with commit 4700833 Jun 23, 2025
30 checks passed
@gabrielbosio gabrielbosio deleted the fix-ci-blocks branch June 23, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants