-
Notifications
You must be signed in to change notification settings - Fork 48
[DNM] Return builtin stats from a contract execution #1252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JulianGCalderon
wants to merge
1
commit into
main
Choose a base branch
from
return-builtin-stats
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8a8e93b
to
7c0fb11
Compare
Benchmark results Main vs HEAD.Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
|
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
11.541 ± 0.082 | 11.401 | 11.703 | 2.32 ± 0.02 |
cairo-native (embedded AOT) |
4.975 ± 0.036 | 4.931 | 5.056 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
5.046 ± 0.033 | 4.982 | 5.104 | 1.01 ± 0.01 |
Benchmark for program dict_snapshot
Open benchmarks
Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
808.6 ± 4.0 | 801.8 | 814.7 | 1.00 |
cairo-native (embedded AOT) |
4870.0 ± 33.1 | 4806.7 | 4908.3 | 6.02 ± 0.05 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
4981.5 ± 69.1 | 4928.1 | 5158.6 | 6.16 ± 0.09 |
Benchmark for program factorial_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
5.367 ± 0.039 | 5.316 | 5.456 | 1.01 ± 0.01 |
cairo-native (embedded AOT) |
5.326 ± 0.037 | 5.286 | 5.416 | 1.00 ± 0.01 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
5.324 ± 0.035 | 5.271 | 5.374 | 1.00 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
5.209 ± 0.044 | 5.161 | 5.321 | 1.05 ± 0.01 |
cairo-native (embedded AOT) |
4.945 ± 0.053 | 4.856 | 5.017 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
5.019 ± 0.065 | 4.877 | 5.103 | 1.01 ± 0.02 |
Benchmark for program linear_search
Open benchmarks
Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
834.9 ± 8.1 | 822.9 | 852.3 | 1.00 |
cairo-native (embedded AOT) |
4932.9 ± 50.7 | 4876.0 | 5011.5 | 5.91 ± 0.08 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
5132.3 ± 44.2 | 5061.6 | 5206.3 | 6.15 ± 0.08 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
549.8 ± 11.0 | 535.5 | 571.9 | 1.00 |
cairo-native (embedded AOT) |
5135.7 ± 66.5 | 4993.7 | 5187.8 | 9.34 ± 0.22 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
5330.2 ± 40.7 | 5284.4 | 5412.3 | 9.70 ± 0.21 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1252 +/- ##
=======================================
Coverage ? 80.19%
=======================================
Files ? 112
Lines ? 29981
Branches ? 0
=======================================
Hits ? 24042
Misses ? 5939
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for returning builtin stats from a contract execution.
The Native builtin stats SHOULD be the same as the ones from a VM execution. We have not tested this thoroughly and it may not be the case. We should compare with the Cairo VM to ensure that we are increase the builtin counters correctly.
NOTE: The CI is failing because this is a breaking change.