Skip to content

[WIP] Temporary fix for 0.3.4 circuit bugs #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 14, 2025
Merged

[WIP] Temporary fix for 0.3.4 circuit bugs #1229

merged 7 commits into from
May 14, 2025

Conversation

JulianGCalderon
Copy link
Contributor

@JulianGCalderon JulianGCalderon commented May 13, 2025 •
edited
Loading

@JulianGCalderon JulianGCalderon changed the base branch from main to v0.3.4 May 13, 2025 15:55
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 88 lines in your changes missing coverage. Please review.

Project coverage is 76.36%. Comparing base (65e08ac) to head (1947da9).

Files with missing lines Patch % Lines
src/libfuncs/circuit.rs 0.00% 73 Missing ⚠️
src/values.rs 0.00% 15 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           v0.3.4    #1229      +/-   ##
==========================================
- Coverage   81.07%   76.36%   -4.71%     
==========================================
  Files         110      110              
  Lines       29312    29408      +96     
==========================================
- Hits        23765    22458    -1307     
- Misses       5547     6950    +1403

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JulianGCalderon JulianGCalderon marked this pull request as ready for review May 14, 2025 18:34
@JulianGCalderon JulianGCalderon changed the title [WIP] Fix 0.3.4 circuit bugs [WIP] Temporary fix for 0.3.4 circuit bugs May 14, 2025
@JulianGCalderon JulianGCalderon merged commit 614e9ca into v0.3.4 May 14, 2025
11 checks passed
@JulianGCalderon JulianGCalderon deleted the v0.3.4-fix branch May 14, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azteca1998 azteca1998 azteca1998 approved these changes

@gabrielbosio gabrielbosio gabrielbosio approved these changes

@FrancoGiachetta FrancoGiachetta FrancoGiachetta approved these changes

@edg-l edg-l Awaiting requested review from edg-l edg-l is a code owner

@igaray igaray Awaiting requested review from igaray igaray is a code owner

@jrchatruc jrchatruc Awaiting requested review from jrchatruc jrchatruc is a code owner

@entropidelic entropidelic Awaiting requested review from entropidelic entropidelic is a code owner

@fmoletta fmoletta Awaiting requested review from fmoletta fmoletta is a code owner

@Oppen Oppen Awaiting requested review from Oppen Oppen is a code owner

@pefontana pefontana Awaiting requested review from pefontana pefontana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JulianGCalderon @codecov-commenter @azteca1998 @gabrielbosio @FrancoGiachetta