Skip to content

Replace cairo programs in types tests #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

FrancoGiachetta
Copy link
Contributor

@FrancoGiachetta FrancoGiachetta commented Jan 9, 2025

Related to #1035

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link

github-actions bot commented Jan 9, 2025

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
base dict_insert.cairo (JIT) 3.842 ± 0.020 3.814 3.879 1.00
base dict_insert.cairo (AOT) 4.003 ± 0.017 3.985 4.042 1.04 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head dict_insert.cairo (JIT) 3.950 ± 0.029 3.903 3.993 1.00
head dict_insert.cairo (AOT) 4.125 ± 0.020 4.092 4.156 1.04 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_snapshot.cairo (JIT) 4.053 ± 0.022 4.016 4.084 1.00
base dict_snapshot.cairo (AOT) 4.194 ± 0.019 4.153 4.230 1.03 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head dict_snapshot.cairo (JIT) 4.166 ± 0.023 4.127 4.201 1.00
head dict_snapshot.cairo (AOT) 4.272 ± 0.029 4.227 4.317 1.03 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 4.075 ± 0.019 4.032 4.099 1.00
base factorial_2M.cairo (AOT) 4.268 ± 0.020 4.231 4.306 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head factorial_2M.cairo (JIT) 4.197 ± 0.027 4.171 4.238 1.00
head factorial_2M.cairo (AOT) 4.391 ± 0.021 4.358 4.415 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 3.630 ± 0.016 3.608 3.655 1.00
base fib_2M.cairo (AOT) 3.827 ± 0.022 3.793 3.871 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head fib_2M.cairo (JIT) 3.718 ± 0.035 3.662 3.779 1.00
head fib_2M.cairo (AOT) 3.912 ± 0.023 3.882 3.963 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search.cairo (JIT) 3.798 ± 0.016 3.758 3.823 1.00
base linear_search.cairo (AOT) 3.930 ± 0.024 3.887 3.959 1.03 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head linear_search.cairo (JIT) 3.914 ± 0.039 3.860 3.999 1.00
head linear_search.cairo (AOT) 4.018 ± 0.030 3.968 4.060 1.03 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 3.903 ± 0.020 3.863 3.939 1.00
base logistic_map.cairo (AOT) 3.983 ± 0.016 3.951 4.001 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head logistic_map.cairo (JIT) 4.036 ± 0.042 3.983 4.113 1.00
head logistic_map.cairo (AOT) 4.101 ± 0.024 4.070 4.152 1.02 ± 0.01

Copy link

github-actions bot commented Jan 9, 2025

Benchmarking results

Benchmark for program dict_insert

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 20.824 ± 0.145 20.654 21.064 102.27 ± 2.73
cairo-native (embedded AOT) 3.955 ± 0.026 3.918 3.988 19.43 ± 0.52
cairo-native (embedded JIT using LLVM's ORC Engine) 3.799 ± 0.020 3.773 3.827 18.66 ± 0.49
cairo-native (standalone AOT with -march=native) 0.204 ± 0.005 0.199 0.216 1.00

Benchmark for program dict_snapshot

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.695 ± 0.016 5.679 5.729 17.71 ± 0.26
cairo-native (embedded AOT) 4.118 ± 0.028 4.072 4.159 12.81 ± 0.21
cairo-native (embedded JIT using LLVM's ORC Engine) 3.985 ± 0.013 3.960 4.001 12.39 ± 0.19
cairo-native (standalone AOT with -march=native) 0.322 ± 0.005 0.318 0.331 1.00

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 14.793 ± 0.065 14.665 14.895 10.90 ± 0.05
cairo-native (embedded AOT) 4.228 ± 0.029 4.189 4.266 3.12 ± 0.02
cairo-native (embedded JIT using LLVM's ORC Engine) 4.025 ± 0.031 3.976 4.075 2.97 ± 0.02
cairo-native (standalone AOT with -march=native) 1.357 ± 0.000 1.357 1.358 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 14.600 ± 0.043 14.551 14.657 182.24 ± 0.89
cairo-native (embedded AOT) 3.769 ± 0.024 3.731 3.808 47.05 ± 0.35
cairo-native (embedded JIT using LLVM's ORC Engine) 3.543 ± 0.029 3.513 3.614 44.23 ± 0.40
cairo-native (standalone AOT with -march=native) 0.080 ± 0.000 0.080 0.081 1.00

Benchmark for program linear_search

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.724 ± 0.035 5.701 5.815 2891.56 ± 87.92
cairo-native (embedded AOT) 3.849 ± 0.042 3.811 3.948 1944.75 ± 61.68
cairo-native (embedded JIT using LLVM's ORC Engine) 3.727 ± 0.012 3.705 3.746 1883.12 ± 56.39
cairo-native (standalone AOT with -march=native) 0.002 ± 0.000 0.002 0.003 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.665 ± 0.024 5.622 5.704 23.34 ± 0.11
cairo-native (embedded AOT) 3.910 ± 0.019 3.882 3.948 16.11 ± 0.09
cairo-native (embedded JIT using LLVM's ORC Engine) 3.848 ± 0.030 3.801 3.886 15.86 ± 0.13
cairo-native (standalone AOT with -march=native) 0.243 ± 0.001 0.242 0.244 1.00

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.46%. Comparing base (f1e895f) to head (3ec10db).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1037      +/-   ##
==========================================
+ Coverage   80.88%   81.46%   +0.58%     
==========================================
  Files         107      107              
  Lines       29470    30187     +717     
==========================================
+ Hits        23836    24592     +756     
+ Misses       5634     5595      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@igaray
Copy link
Collaborator

igaray commented Feb 6, 2025

Superceded by #1050

@igaray igaray closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants