Skip to content

feat(RAIN-94565): Added 11 services for TF permissions 20.0.0 #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 4, 2025

Conversation

LMAX-iwnf
Copy link
Contributor

@LMAX-iwnf LMAX-iwnf commented Apr 3, 2025

Summary

Adding permissions for upcoming services including:

  1. Free Tier
  2. ACM-PCA
  3. Lambda(partial)
  4. Schemas(partial)
  5. Scheduler
  6. Lakeformation
  7. DynamoDB(Partial)
  8. Appconfig
  9. AppFlow
  10. EBS
  11. DATASYNC

How did you test this change?

Testing in DEV account
https://docs.google.com/document/d/1raSa62A7Q1sqbdYhxU2z73OrMVjS7odE995yfnN6NKI/edit?tab=t.0

Issue

https://lacework.atlassian.net/browse/RAIN-94565

Free Tier

ACM-PCA

Lambda(partial)

Schemas(partial)

Scheduler

Lakeformation

DynamoDB(Partial)

describe_contributor_insights

get_resource_policy

Appconfig

AppFlow

EBS
main.tf Outdated
"appflow:ListConnectorEntities",
"appflow:ListConnectorFields",
"appflow:ListConnectors",
"appflow:ListFlows",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ListFlows is in SecurityAudit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the ones that are not needed as well

main.tf Outdated
statement {
sid = "EBS"
actions = ["ebs:GetSnapshotBlock",
"ebs:ListChangedBlocks",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are not using ListChangedBlocks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

| | scheduler:ListTagsForResource | |
| SCHEMAS | schemas:GetCodeBindingSource | * |
| DATASYNC | datasync:DescribeTaskExecution | * |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me

Copy link
Contributor

@jjzhangjjzhang jjzhangjjzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good to me

@LMAX-iwnf LMAX-iwnf merged commit 2207b0a into main Apr 4, 2025
11 checks passed
@LMAX-iwnf LMAX-iwnf deleted the Add_permission_for_20.0.0 branch April 4, 2025 15:59
@lacework-releng lacework-releng mentioned this pull request May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants