feat: Sensible pg defaults
#1545
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
shoooe
commented
Aug 10, 2025
| /** | ||
| * @todo: docs | ||
| */ | ||
| types?: Record<number, (value: string) => any> |
There was a problem hiding this comment.
Naming is taken from the equivalent option in pg: https://node-postgres.com/apis/client#new-client
shoooe
commented
Aug 10, 2025
| node_modules | ||
| .vscode | ||
| .idea | ||
| .DS_Store |
There was a problem hiding this comment.
This is a pretty common macOS file that gets generated by the OS.
|
@igalklebanov The failing test says:
which doesn't look like an actual test failure caused by this PR. Is this perhaps also in the main trunk? |
|
@shoooe is attempting to deploy a commit to the Kysely Team Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1544
Note to self:
Run tests with: