React Native should use CJS #1452
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
commit: |
|
Hey 👋 Thanks! 🙏 Relevant thread: expo/expo#36551 (comment) |
|
Curious if there was any progress or plans to get this out? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, builds in Expo 53 break (expo/expo#36544) because the
package.json:exportsfield is now enabled by default in Metro bundler.This causes the ESM version of Kysely to get imported, which is an issue because Metro can't do dynamic imports yet (facebook/metro#52) which is used in the
FileMigrationProvider: https://github.com/kysely-org/kysely/blob/master/src/migration/file-migration-provider.ts#L38-L43This is a quick fix, but IMO the
FileMigrationProvidershould get its own sub path inpackage.json:exportsso that RN can use the ESM version as well. If that's more acceptable even though it would be a breaking change, let me know and I can update the PR.