-
Couldn't load subscription status.
- Fork 350
feat: type-safe JSON insertions/updates, eb.jval & sql.jval.
#1130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
igalklebanov
wants to merge
7
commits into
kysely-org:next
Choose a base branch
from
igalklebanov:stricter-json
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Serialized<O>, stricter JSONColumnType<O>, eb.valSerialized & sql.valSerialized.Serialized<O>, stricter JSONColumnType<O> insertions/updates, eb.valSerialized & sql.valSerialized.
Serialized<O>, stricter JSONColumnType<O> insertions/updates, eb.valSerialized & sql.valSerialized.JSONColumnType<O> insertions/updates, eb.valSerialized & sql.valSerialized.
JSONColumnType<O> insertions/updates, eb.valSerialized & sql.valSerialized.JSONColumnType<O> insertions/updates, eb.valSerialized & sql.valSerialized.
JSONColumnType<O> insertions/updates, eb.valSerialized & sql.valSerialized.JSONColumnType<O> insertions/updates, eb.valJson & sql.valJson.
JSONColumnType<O> insertions/updates, eb.valJson & sql.valJson.eb.valJson & sql.valJson.
a84367a to
124c0dc
Compare
8e3dbf7 to
a7abe0f
Compare
b2b78db to
ae5cb1e
Compare
a7abe0f to
5262c17
Compare
5262c17 to
1cda284
Compare
1cda284 to
8372531
Compare
fc3c620 to
5ce2df7
Compare
5ce2df7 to
01b823d
Compare
Co-authored-by: Eric So <56284867+ericsodev@users.noreply.github.com> Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>
01b823d to
38a3e83
Compare
introduce ValueNode.serialized. introduce eb.valSerialized. introduce sql.valSerialized. fix json-traversal test suite. fix null handling @ compiler. rename to `valJson`. add instructions in errors. typings test inserts. call the new type `Json` instead, to not introduce a breaking change. add missing json column @ Getting Started. add `appendSerializedValue`. Renames `valJson` to `jval` for JSON value wrapping Renames the `valJson` method to `jval` for wrapping JSON values when inserting or updating columns. This change promotes brevity and consistency throughout the codebase. The name change affects the expression builder, SQL raw builder, and documentation. fix jsdocs check. ValueNode.createSerialized.
38a3e83 to
fd59021
Compare
f13491f to
90d6c71
Compare
f3c3650 to
9adaf87
Compare
bdf82d9 to
33e2a45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api
Related to library's API
deprecation
Something is/should be deprecated
enhancement
New feature or request
internal
typescript
Related to Typescript
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
JSONColumnTypedemands manual serialization before passing values in insertions/updates. Once you do that, it is not that type-safe - you can pass any string value really.This PR deprecates
JSONColumnType, and introduces the stricterJsontype that enforces type-safe insertions/updates.Using a branded type as the
InsertTypeandUpdateTypeAND as the return value of new serialization helpers inExpressionBuilderandsqltemplate tag, users can now insert/update and serialize their JSON objects/arrays safely into JSON columns.Compilers/plugins can serialize the objects/arrays differently, as the value is passed around in a
ValueNodewith aserializedflag. The default serialization method is, well,JSON.stringify.If you want the non-type-safe old
JSONColumnType.. we don't encourage it, but you can continue usingJSONColumnType(until we decide to remove it) or just use:For a readonly
Json, use: