Skip to content

Conversation

@rithviknishad
Copy link
Contributor

Added support for history replace when using setQueryString of useQueryParams by setting historyReplace option.

Associated Issues

@kyeotic
Copy link
Owner

kyeotic commented Mar 13, 2025

@rithviknishad This looks great, and you even added a test! However, the actions jobs are all failing due to deprecations in the job themselves. I will need to fix this before I can get this merged. This might take me a few days, as my plate is pretty full this week.

I will get to this though, I promise.

@rithviknishad
Copy link
Contributor Author

@rithviknishad This looks great, and you even added a test! However, the actions jobs are all failing due to deprecations in the job themselves. I will need to fix this before I can get this merged. This might take me a few days, as my plate is pretty full this week.

I will get to this though, I promise.

Thanks! Would really love to see this released! Thanks for maintaining such a clean and minimal routing solution for react!

@areebahmeddd
Copy link

@kyeotic If the workflows have been updated, could we rerun this?

@kyeotic kyeotic changed the base branch from main to basePathMatching March 13, 2025 23:22
@kyeotic kyeotic changed the base branch from basePathMatching to main March 13, 2025 23:22
@kyeotic
Copy link
Owner

kyeotic commented Mar 13, 2025

@rithviknishad You didnt give me permission to push to your fork, so I can't try this myself, so can you push an empty commit? Github doesn't seem to be running jobs on the correct base for main.

@rithviknishad
Copy link
Contributor Author

@rithviknishad You didnt give me permission to push to your fork, so I can't try this myself, so can you push an empty commit? Github doesn't seem to be running jobs on the correct base for main.

@kyeotic I've merged the latest main on to this branch; Could you try now?

Weird, I had given you permission to push to my fork:

image

@kyeotic kyeotic merged commit 7eeb12e into kyeotic:main Mar 14, 2025
6 checks passed
@kyeotic
Copy link
Owner

kyeotic commented Mar 14, 2025

This has been published under 4.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

useQueryParams Adds New History Entries When Updating Search Parameters

3 participants