forked from sgl-project/sglang
-
Notifications
You must be signed in to change notification settings - Fork 0
Support different tp_size - Part 1 p/d dynamic connection #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yuan-luo
wants to merge
5
commits into
mooncake_transfer_engine
Choose a base branch
from
sgl_different_tp_size
base: mooncake_transfer_engine
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e62a485
to
58b4d73
Compare
6 tasks
fc3c6ff
to
544534c
Compare
36f32ff
to
ebcdc7b
Compare
yuan-luo
commented
Apr 9, 2025
4ae00f0
to
b032106
Compare
ShangmingCai
reviewed
Apr 9, 2025
ShangmingCai
reviewed
Apr 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
69fa651
to
326e583
Compare
35abefb
to
ccaac4f
Compare
ccaac4f
to
0664822
Compare
stmatengss
reviewed
Apr 11, 2025
7d7e521
to
b5fafe7
Compare
b5fafe7
to
0f33b49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To support different tensor parallel size on prefill and decode. This PR is Part 1, supporting prefill / decode connection establishment and register to bootstrap server.
Modifications
Checklist