Skip to content

WIP: Support multi prefill instances on one node #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: mooncake_transfer_engine
Choose a base branch
from

Conversation

yuan-luo
Copy link
Collaborator

@yuan-luo yuan-luo commented Apr 7, 2025

Motivation

Modifications

Checklist

@yuan-luo yuan-luo force-pushed the sgl_multi_prefill branch from a50d96e to 8d3d1ee Compare April 7, 2025 06:29
@yuan-luo yuan-luo changed the title WIP: Support multi prefill on one node WIP: Support multi prefill instances on one node Apr 7, 2025
@yuan-luo
Copy link
Collaborator Author

yuan-luo commented Apr 7, 2025

Per offline discussed with @ShangmingCai, suspend this PR and focus on supporting different tp_size for the moment.

@yuan-luo yuan-luo force-pushed the sgl_multi_prefill branch from 8d3d1ee to 6f386b4 Compare April 7, 2025 09:34
@yuan-luo yuan-luo force-pushed the sgl_multi_prefill branch from 6f386b4 to 9b4b682 Compare April 7, 2025 10:57
@Hongbosherlock
Copy link

Per offline discussed with @ShangmingCai, suspend this PR and focus on supporting different tp_size for the moment.

When do we get back to this PR?

@ShangmingCai
Copy link
Collaborator

ShangmingCai commented Apr 22, 2025

Per offline discussed with @ShangmingCai, suspend this PR and focus on supporting different tp_size for the moment.

When do we get back to this PR?

@Hongbosherlock We need to discuss this with the sglang team since supporting multi-prefill on the same node requires changing the mini_lb and bootstrap impl. Currently, this is not a high-priority issue since it is not the case that real deployment will adopt.

@Hongbosherlock
Copy link

Per offline discussed with @ShangmingCai, suspend this PR and focus on supporting different tp_size for the moment.

When do we get back to this PR?

@Hongbosherlock We need to discuss this with the sglang team since supporting multi-prefill on the same node requires changing the mini_lb and bootstrap impl. Currently, this is not a high-priority issue since it is not the case that real deployment will adopt.

Is it now possible to use multiple Docker containers on one machine to achieve xPyD? Do the P nodes within the different Docker containers need to have the same port?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants