fix(exporter): query more than 10000, avoid sort on _id #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinRousselet
changed the title
afondard
reviewed
Nov 5, 2025
Comment on lines
+208
to
+209
| if (groupsCount.total === 1 && groupsCount.hits[0]._id === groupId) { | ||
| return; |
There was a problem hiding this comment.
Why not throwing an error if a group with the same name exists?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR changes the search request for the export of measures to a scroll request allowing more than 10000 results.
It also removes the default sort by _id as it is not needed anymore
It also removes the filter on doc _id in
AssetGroupsServicecheckGroupNamefunction.How should this be manually tested?