fix(measures): add device origin groups field to measure documents #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etrousset
requested changes
Oct 1, 2025
There was a problem hiding this comment.
- make a function to fill the source object to avoid copying the same code several time and allow future field addition with avoiding forgetting some places.
Repeated code :
source: { deviceMetadata: metadata, groups, id: _id, metadata: deviceMetadataChanges, model: model, reference: reference, type: "device", },
- Implement the TODO and remove se code (should be a matter of using the same source object build function
etrousset
approved these changes
Oct 2, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Oct 2, 2025
## [3.0.0-next.13](v3.0.0-next.12...v3.0.0-next.13) (2025-10-02) ### Bug Fixes * **measures:** add device groups field to origin of measures documents ([#441](#441)) ([35aa43d](35aa43d))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR adds missing origin device groups in measure documents during ingestion.
Other changes
Linked to issue KZLPRD-1039 prevent the ingestion with no measures