-
Notifications
You must be signed in to change notification settings - Fork 8
feat(groups): rework asset groups into broader groups #424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# [2.5.0-dev.3](v2.5.0-dev.2...v2.5.0-dev.3) (2024-12-05) ### Features * **softTenants:** add softTenant ids to assets measures documents ([#383](#383)) ([1b36fe0](1b36fe0))
# [2.5.0-dev.4](v2.5.0-dev.3...v2.5.0-dev.4) (2024-12-05) ### Features * add editor hint support ([#386](#386)) ([a9b62df](a9b62df))
# [2.5.0-dev.5](v2.5.0-dev.4...v2.5.0-dev.5) (2024-12-05) ### Bug Fixes * **assetservice:** can't replace metadata if not present in asset ([#384](#384)) ([eb65c0a](eb65c0a))
# [2.5.0](v2.4.4...v2.5.0) (2024-12-05) ### Bug Fixes * **assetservice:** can't replace metadata if not present in asset ([#384](#384)) ([eb65c0a](eb65c0a)) * backport fix ([#380](#380)) ([5392b56](5392b56)) ### Features * add editor hint support ([#386](#386)) ([a9b62df](a9b62df)) * **measure:** allow measures to be pushed on Assets via API (no devices) ([#344](#344)) ([c1073c1](c1073c1)) * **softTenants:** add softTenant ids to assets measures documents ([#383](#383)) ([1b36fe0](1b36fe0))
…s et par groupes (#388) * feat: add optional type for asset group * fix: set type optional * fix: change allow null for type
# [2.6.0-beta.1](v2.5.0...v2.6.0-beta.1) (2025-01-08) ### Features * trigger release ([9c82581](9c82581))
## [2.5.1](v2.5.0...v2.5.1) (2025-01-09) ### Bug Fixes * **measure:** add mutex to asset update to prevent race condition ([#389](#389)) ([53371f4](53371f4))
Co-authored-by: rolljee <n.riquelmebareiro@gmail.com>
## [2.6.0-dev.1](v2.5.1...v2.6.0-dev.1) (2025-01-22) ### Features * update deps ([#393](#393)) ([1b9b936](1b9b936))
* fix(measure): add mutex to asset update to prevent race condition (#389) * chore(release): 2.5.1 [skip ci] ## [2.5.1](v2.5.0...v2.5.1) (2025-01-09) ### Bug Fixes * **measure:** add mutex to asset update to prevent race condition ([#389](#389)) ([53371f4](53371f4)) * docs: add since badges to ingestMeasure(s) method (#390) Co-authored-by: rolljee <n.riquelmebareiro@gmail.com> * feat: update deps (#393) * chore: update deps * chore(release): 2.6.0-dev.1 [skip ci] ## [2.6.0-dev.1](v2.5.1...v2.6.0-dev.1) (2025-01-22) ### Features * update deps ([#393](#393)) ([1b9b936](1b9b936)) * fix: typo in packages/package.json * chore(release): 2.6.0-dev.2 [skip ci] ## [2.6.0-dev.2](v2.6.0-dev.1...v2.6.0-dev.2) (2025-01-22) ### Features * trigger release ([9c82581](9c82581)) ### Bug Fixes * conflict between ([adf8d0f](adf8d0f)) * typo in packages/package.json ([9b6c495](9b6c495)) --------- Co-authored-by: Sébastien Rodriguez <sebtiz13@gmail.com> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> Co-authored-by: Juiced66 <80784430+Juiced66@users.noreply.github.com>
## [2.6.0-beta.2](v2.6.0-beta.1...v2.6.0-beta.2) (2025-01-22) ### Bug Fixes * Trigger release ([5025a0f](5025a0f))
* feat!: remove KDM measure declaration BREAKING CHANGES KDM now will not import basics measure and let responsibility to users * fixup! feat!: remove KDM measure declaration BREAKING CHANGES KDM now will not import basics measure and let responsibility to users * fix: init measures for test app * fixup! fix: init measures for test app
fd554d5 to
b3d6ada
Compare
Juiced66
approved these changes
Jul 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, hard to review but
- test are passing in ci and locally
- no v3 changes has been overwrote
For the feature itself it's ok, for the UX we should have a migration guide (or script ideally) at least for people that will need to migrate their groups to the new format in the new collection.
inkedsquid
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does ?
This PR refont the assetsGroups into Groups.
Groups don't have parents and children anymore but a path containing it's ancestors.
Other changes
This PR reallign the 3.0.0 on the evolutions of the 2.0.0