fixes for JSONfeed item.content #439
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec allows to have both text and HTML elements, and the feedparser content key supports different content types. Adjust the code to look at both source elements and add all that are present. Signed-off-by: Beat Bolli <dev@drbeat.li>
HTML has generally more useful information than text, so let's move it first in the content list. Users that want text can still iterate over the list and pick the text type. Signed-off-by: Beat Bolli <dev@drbeat.li>
The spec says that at least one element is mandatory. Verify this and raise an exception if both are missing. Signed-off-by: Beat Bolli <dev@drbeat.li>
Signed-off-by: Beat Bolli <dev@drbeat.li>
|
Ping? |
|
Ping again? This is now pending since one year... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After trying to parse the first JSON feed I found in the wild [1], I realized that the content element should be a list. This series fixes this defect and prefers HTML content over text.
[1] https://leahneukirchen.org/trivium/index.json