Skip to content

fix: change action type OPEN_IN_APP_STORE to OPEN_APP_IN_APP_STORE #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025
Merged

fix: change action type OPEN_IN_APP_STORE to OPEN_APP_IN_APP_STORE #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Examples/ExampleSwiftUI/MainApp.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ struct MainApp: App {
// (Optional) Configure a custom base URL to your API host
// options.baseURL = "https://your-domain.com/api"

// (Optional) Configure the App Store id, required by the action "OPEN_IN_APP_STORE"
// (Optional) Configure the App Store id, required by the action "OPEN_APP_IN_APP_STORE"
options.appStoreId = 409_201_541
}
}
Expand Down
2 changes: 1 addition & 1 deletion Examples/ExampleUIKit/SceneDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class SceneDelegate: UIResponder, UIWindowSceneDelegate {
// (Optional) Configure a custom base URL to your API host
// options.baseURL = "https://your-domain.com/api"

// (Optional) Configure the App Store id, required by the action 'OPEN_IN_APP_STORE'
// (Optional) Configure the App Store id, required by the action 'OPEN_APP_IN_APP_STORE'
options.appStoreId = 409_201_541
}
}
Expand Down
4 changes: 2 additions & 2 deletions Sources/OnLaunch/API/ApiActionDto.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
self = .dismiss
case "LINK":
self = .link
case "OPEN_IN_APP_STORE":
case "OPEN_APP_IN_APP_STORE":

Check warning on line 14 in Sources/OnLaunch/API/ApiActionDto.swift

View check run for this annotation

Codecov / codecov/patch

Sources/OnLaunch/API/ApiActionDto.swift#L14 

Added line #L14 was not covered by tests
self = .openInAppStore
default:
self = .unknown(rawValue)
Expand All @@ -25,7 +25,7 @@
case .link:
return "LINK"
case .openInAppStore:
return "OPEN_IN_APP_STORE"
return "OPEN_APP_IN_APP_STORE"

Check warning on line 28 in Sources/OnLaunch/API/ApiActionDto.swift

View check run for this annotation

Codecov / codecov/patch

Sources/OnLaunch/API/ApiActionDto.swift#L28 

Added line #L28 was not covered by tests
case let .unknown(value):
return value
}
Expand Down
Loading