-
Notifications
You must be signed in to change notification settings - Fork 52
Harden bridge-marker SCC: restrict privileges, enforce non-root, allow projected volumes #2336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Disallow hostDir volume plugins. - Restrict volume types to configMap and emptyDir. - Restrict volumes access to basic folders. Projected volume is required for ServiceAccount token mounts. Signed-off-by: Ram Lavi <ralavi@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
🔒 SCC Non-Default Capabilities Review
|
As a preliminary step to the next commit where runtime dependencies are hardened, mounting /tmp. This is required for compatibility with Go libraries and client-go when using readOnlyRootFilesystem. This commit mounts an emptyDir at /tmp to provide writable scratch space for the container. This change should also occur on the repo itself, but until it does, and in order to allow for smooth bump when it occurs - it should stay. Signed-off-by: Ram Lavi <ralavi@redhat.com>
- Enable readOnlyRootFilesystem for better container isolation. - Require containers to run as non-root users. - Set SELinux context type to MustRunAs for confinement. Signed-off-by: Ram Lavi <ralavi@redhat.com>
…d-only rootfs - Configure container to run as non-root user explicitly (UID 1001). - Enable read-only root filesystem at container level. - Ensure consistent non-root enforcement across architectures. This change should also occur on the repo itself, but until it does, and in order to allow for smooth bump when it occurs - it should stay. Signed-off-by: Ram Lavi <ralavi@redhat.com>
946e952
to
7ab3e0b
Compare
|
checked on kcli and it runs smoothly:
|
/hold cancel |
What this PR does / why we need it:
This PR improves the security posture of the bridge-marker DaemonSet in OpenShift by hardening its SecurityContextConstraints (SCC) and enforcing best practices.
Special notes for your reviewer:
To anticipate reviewers request, commented on the PR why I did NOT remove other SCCs.
Release note: