Update lifecycle release selector for s390x

[aditi-sharma-1]

What this PR does / why we need it:

Full support for the s390x architecture is available starting from CNAO v0.98.2.

This pull request updates the lifecycle CI pipeline and end-to-end test configurations to use v0.98.2 as the starting version for s390x, so that tests can run successfully. These changes help improve compatibility for the s390x architecture.

Release note:

NONE

[kubevirt-bot]

Hi @aditi-sharma-1. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qinqon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[oshoval]

Thanks

instead the change please consider exporting the RELEASES_SELECTOR you want in the s390x lane
i do understand that you will need to update it from time to time, but it can be nicer
wdyt ?

alternative is to auto detect if a release has s390x and skip it if not, and then no need additional changes anymore
It will be best if we can find something minimal that does the job please

cc @RamLavi wdyt?

[ashokpariya0]

Good suggestion!

I think we can approach it like this:

1. Add version 0.98.2 to the list in check-patch.e2e-lifecycle-k8s.sh.

if we don't want to do that then we can skip lifecycle for s390x as s390x supported version 0.98.2 is not release under HCO yet

if we are okay with 1 then
For the s390x Prow lane, we can use RELEASES_DESELECTOR env instead of RELEASES_SELECTOR:

cluster-network-addons-operator/test/releases/releases.go

Line 62 in ec5c996

if releasesDeselectorRaw, found := os.LookupEnv("RELEASES_DESELECTOR"); found {

However, one issue I noticed is that 0.98.2 is not currently part of the populated release list. not sure why ???
You can confirm that from the output shown here: https://sharepad.io/p/5L7nfm9

It seems that the version isn't added in the releases initialization:

cluster-network-addons-operator/test/releases/releases.go

Line 46 in ec5c996

Expect(validateReleasesSelector(releases, releasesSelectorRaw)).NotTo(HaveOccurred())

So before anything else, we’ll need to ensure 0.98.2 is included in the releases definition.

[oshoval]

Thank you for looking on it deeply

0.98.2 is just a release on main, so HCO can consume it, since it doesnt belong to a stable branch we should not add it to RELEASES_SELECTOR

Please just set RELEASES_SELECTOR as you wish in the job, but make sure please that someone maintains it

Possible idea for the future - to think on a way that auto select the 3 latest stable branches that are formal, or at least to have one place where we add it manually in the beginning and from there, helper scripts are populating it to the required place, i.e 390x lane

[ashokpariya0]

just setting export RELEASES_SELECTOR=0.98.2 is not working, it is failing at below check, as explained earlier

cluster-network-addons-operator/test/releases/releases.go

Line 46 in ec5c996

Expect(validateReleasesSelector(releases, releasesSelectorRaw)).NotTo(HaveOccurred())

Setting RELEASES_SELECTOR alone won't work until we add 0.98.2 to the populated releases list.

[oshoval]

we can't add it
we add only latest patch on stables and this isn't stable

can you please try to think about other way / debug it deeper ?

[oshoval]

@RamLavi wdyt ?

[RamLavi]

I don't think we should use 0.98.2, as @oshoval said.
The first release that will have a stable branch AND support the new arch - IIUC is the next one (0.99.0) - which is currently pending merge (once quay outage is over it sould be merged quickly).
I suggest to use that version instead

[oshoval]

0.99 is out (well on main still)
once there is a stable branch
#2284
and then we can try according suggested in this thread ?
(strive to keep it as simple as possible please, and as low maintenance we need)

[ashokpariya0]

okay, noted.