ci: update golangci-lint to v2 #488
Merged
+168
−162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
size/L
|
/cc @saschagrunert |
k8s-ci-robot
added
the
cncf-cla: yes
.golangci.yml file has been migrated by running `golangci-lint migrate` Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
these linters were giving a warning similar to ``` WARN [linters_context] gocritic: no need to enable check "appendAssign": it's already enabled WARN [linters_context] gocritic: no need to enable check "argOrder": it's already enabled ``` Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
- fix QF1001 and QF1006 - simplify if condition after fixing static check Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
akhilerm
force-pushed
the
update-golangci-v2
branch
from
178f2a9 to
7fe767c
Compare
saschagrunert
approved these changes
Mar 25, 2025
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akhilerm, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.