build: update to go1.22.0 #449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
akhilerm
force-pushed
the
update-go1.22
branch
from
6179887 to
e40bbc4
Compare
k8s-ci-robot
added
the
do-not-merge/work-in-progress
cpanato
reviewed
Sep 5, 2024
cpanato
requested changes
Sep 5, 2024
|
/retest |
cpanato
reviewed
Sep 6, 2024
k8s-ci-robot
added
size/M
akhilerm
force-pushed
the
update-go1.22
branch
from
64f61c0 to
a1359d9
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/test pull-publishing-bot-image |
|
Fix for |
akhilerm
force-pushed
the
update-go1.22
branch
from
a1359d9 to
a9121a9
Compare
|
@cpanato PTAL |
|
/cc @cpanato @saschagrunert Can you take a look ? |
cpanato
requested changes
Sep 26, 2024
akhilerm
force-pushed
the
update-go1.22
branch
from
a9121a9 to
52a0f12
Compare
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
Ref: go-critic/go-critic#1376 Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
Ref: go-critic/go-critic#1281 Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
goerr113 and perfsprint linters are removed since the fixes reduces the readability Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
akhilerm
force-pushed
the
update-go1.22
branch
from
52a0f12 to
2239c54
Compare
cpanato
added
the
tide/merge-method-squash
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akhilerm, cpanato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTES TO REVIEWERS:
Reviewing commit by commit will help understand why certain linters are removed with references to the linter repositories. Also linters that were reporting non trivial fixes / sacrificing readability has been disabled for now.