-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Controller: Fix SSL session ticket path. #13645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…lder Move ssl tickets storage to ssl subdirectory
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: VojtechBuba The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @VojtechBuba! |
Hi @VojtechBuba. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Please also implement a test, so we are not hitting this issue again in the future. Thank you! |
/retitle Controller: Fix SSL session ticket path. |
@Gacko I'm sorry, but i am not able to do that, because i`m not a Go programmer. I hope, that we can somehow figure this out. |
I'm afraid of just merging this, even though it looks like a simple fix, because we already had more than enough complaints regarding simple looking, but untested changes in the past. |
I'm going to test this as soon as I got some time. |
@Gacko Thank you very much |
What this PR does / why we need it:
Fix path for storing ssl session tickets key. Docker container does not have permission to write to
/etc/ingress-controller
because it is owned by root.Types of changes
Which issue/s this PR fixes
#13635
How Has This Been Tested?
I'm not able to test that, i just try to speed up the process.
Checklist: