-
Notifications
You must be signed in to change notification settings - Fork 163
blog post in post quantum crypto in k8s #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @datosh! |
Signed-off-by: Fabian Kammel <fabian.kammel@control-plane.io>
6a12508
to
d5013cb
Compare
Signed-off-by: Fabian Kammel <fabian.kammel@control-plane.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Composition/writing check. No real grammar/punctuation editing needed. However, one suggestion on article flow, and one link needs to be replaced.
The rest of the links all look OK.
Note that I have no expertise in the cryptography details covered by the article.
Signed-off-by: Fabian Kammel <fabian.kammel@control-plane.io>
Thank you, for taking the time to review this @jberkus |
Signed-off-by: Fabian Kammel <fabian.kammel@control-plane.io>
@kubernetes/sig-security-pr-reviews is this article OK to publish (in terms of cryptography / infosec message)? |
Co-authored-by: Tim Bannister <193443691+lmktfy@users.noreply.github.com>
Co-authored-by: Tim Bannister <193443691+lmktfy@users.noreply.github.com>
Signed-off-by: Fabian Kammel <fabian.kammel@control-plane.io>
We should be able to get eyes on this next week. |
Signed-off-by: Fabian Kammel <fabian.kammel@control-plane.io>
/LGTM. I don't have super in-depth crypto knowledge, but like the post and learned from the content. Nice work @datosh |
Signed-off-by: Fabian Kammel <fabian.kammel@control-plane.io>
@EthanHeilman is the general info in this post up-to-date in terms of the cryptography? |
Signed-off-by: Fabian Kammel <fabian.kammel@control-plane.io>
Pushed 53a7858 Based on some feedback from @EthanHeilman: "While true for some PQ algorithms, ML-DSA, FN-DSA have roughly comparable signing performance as EC-DSA and even outperforms EC-DSA at NIST level I. See https://pqshield.github.io/nist-sigs-zoo/ They are about 2-5x slower in signing." |
@jberkus After the most recent commit it looks good to me |
OK, this is ready for more reviews (I won't, as @datosh is a colleague) |
Nice blog. |
`X25519Kyber768Draft00`. This was also enabled by default if | ||
`Config.CurvePreferences` was `nil`. Kubernetes v1.32 used Go 1.23. However, | ||
Go 1.24 removed the draft support and replaced it with the standardized version | ||
`X25519MLKEM768`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
X25519Kyber768Draft00 was to kick the tires: I don't think we can expect Go to carry around a preliminary version. Given the short release cycles of Go, soon enough every Go version will support X25519MLKEM768.
There is a more serious pitfall: if you compile with Go 1.24, but use go 1.20
in go.mod
you still won't get X25519MLKEM768.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can expect Go to carry around a preliminary version.
Do you think I should reword this section, @bwesterb? I did not intend to put blame on the Go team. I think the approach chosen worked very well!
This section was intended to highlight that the details of the chosen parameters and Go versions are important to get right, if you are an early adopter.
@kubernetes/sig-contributor-experience-pr-reviews, PTAL |
Signed-off-by: Fabian Kammel <fabian.kammel@control-plane.io>
4d81b9a
to
24b6aa4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a high-quality piece of writing.
I'm not an expert of the field but it looks great and very informative!
Co-authored-by: Graziano Casto <graziano.casto@outlook.com>
@mfahlandt @palnabarun could you take a look at this so we can merge this as a draft and schedule for release? This was already reviewed from a technical perspective from several people. Also @lmktfy gave his informal 👍, but since we work at the same company we would like to get an 'independent' approval on this. |
Since this is marked as draft, we can merge until we're ready to publish. /lgtm |
Hi @datosh :) |
Given #582 (comment) /approve |
How about this? |
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: datosh, lmktfy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hey 👋
I recently spend some time researching the current state of post quantum cryptography in the cloud native industry.
For some topics I found little to no information especially in the Kubernetes ecosystem, so I thought I share my findings with the community!
Discussion on Slack:
Happy for any comments or suggestions on the post.
/cc @lmktfy