Skip to content

Remove calico in favor of upstream support #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jsturtevant
Copy link
Contributor

@jsturtevant jsturtevant commented Mar 27, 2025

Reason for PR:

Calico has support see https://docs.tigera.io/calico/latest/getting-started/kubernetes/windows-calico/operator. These images and other tooling didn't work due to #347.

We are using upstream in testing now: kubernetes-sigs/windows-testing#494

Issue Fixed:

Issue #

Requirements

  • Sqaush commits
  • Documentation
  • Tests

Notes:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 27, 2025
@k8s-ci-robot k8s-ci-robot requested a review from jayunit100 March 27, 2025 21:11
@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from marosset March 27, 2025 21:11
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 27, 2025
@jsturtevant
Copy link
Contributor Author

/assign @marosset

@jsturtevant
Copy link
Contributor Author

CI is using the latest now installed via the operator

@jsturtevant
Copy link
Contributor Author

this is mostly good to go, was just waiting for kubernetes-sigs/cluster-api-provider-azure#5523 to merge so we aren't using the work here. Those updates are waiting a patch release of calico helm charts.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2025
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
@jsturtevant jsturtevant force-pushed the remove-calico-sample branch from 6a0d095 to 20020b6 Compare April 11, 2025 22:09
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2025
@jsturtevant jsturtevant merged commit 5f77809 into kubernetes-sigs:master Jun 2, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants