Skip to content

Update load balancers versions to Nginx 1.28.0, Haproxy 3.1.7 #12178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2025
Merged

Update load balancers versions to Nginx 1.28.0, Haproxy 3.1.7 #12178

merged 1 commit into from
May 24, 2025
+2 −2

Conversation

guoard
Copy link
Contributor

@guoard guoard commented May 1, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:

Does this PR introduce a user-facing change?:
NONE

Update load balancers versions to Nginx 1.28.0, Haproxy 3.1.7

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 1, 2025
@k8s-ci-robot k8s-ci-robot requested review from MrFreezeex and yankay May 1, 2025 10:04
@k8s-ci-robot
Copy link
Contributor

Hi @guoard. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 1, 2025
@VannTen
Copy link
Contributor

VannTen commented May 10, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 10, 2025
@VannTen
Copy link
Contributor

VannTen commented May 10, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 10, 2025
@VannTen
Copy link
Contributor

VannTen commented May 10, 2025

The version does not appear to exists ?

@guoard
Copy link
Contributor Author

guoard commented May 11, 2025 •
edited
Loading

The version does not appear to exists ?

As discussed here, the images need to be updated manually.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2025
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 12, 2025
@yankay
Copy link
Member

yankay commented May 14, 2025

/retest

@tico88612 tico88612 added this to the 2.29 milestone May 21, 2025
@tico88612
Copy link
Member

/retest

@tico88612
Copy link
Member

@guoard could you rebase your PR?

@guoard
Copy link
Contributor Author

guoard commented May 24, 2025

@guoard could you rebase your PR?

Done.

tico88612
tico88612 approved these changes May 24, 2025
View reviewed changes
Copy link
Member

@tico88612 tico88612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guoard, tico88612, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c89c34f into kubernetes-sigs:master May 24, 2025
45 checks passed
@guoard guoard deleted the patch-2 branch May 24, 2025 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tico88612 tico88612 tico88612 approved these changes

@MrFreezeex MrFreezeex Awaiting requested review from MrFreezeex

@yankay yankay Awaiting requested review from yankay

Assignees

@VannTen VannTen

@tico88612 tico88612

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
2.29
Development

Successfully merging this pull request may close these issues.
5 participants
@guoard @k8s-ci-robot @VannTen @yankay @tico88612