Move some approvers to emeritus #12156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for you work !
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
approved
|
/label ci-short |
|
/retest |
|
Indeed kind of off project during the last 12 months, will try to get back in the game if I manage to back my personal life/work life balance 🙏 |
|
/unhold Thanks for the work ! |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tico88612, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind cleanup
What this PR does / why we need it:
Move some approvers to emeritus.
Mainly to have more helpful hints from Prow on who to assign after LGTM is given
Based on devstats + github kubespray activity from what I can see.
@floryut @oomichi @cristicalin @liupeng0518
Please respond if I've misread the metrics and you're in fact still active approvers :)
Thanks for all your work !
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Let's wait until the end of May to merge this.
/hold
Does this PR introduce a user-facing change?: