-
Notifications
You must be signed in to change notification settings - Fork 6.7k
fix: do not mount hubble-ui tls volume when cilium_hubble_tls_generate is false #12143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not mount hubble-ui tls volume when cilium_hubble_tls_generate is false #12143
Conversation
Welcome @atobaum! |
Hi @atobaum. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Hi @yankay, PR passed the test. Please check PR again. If I have to do something, please tell me. Thank you. |
Thanks @atobaum HI @cyclinder |
Hi @cyclinder, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delayed review. the changes looks good.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atobaum, cyclinder, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@yankay, Please for final approval |
/kind bug |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix hubble-ui deployment to not renders tls volume when the
cilium_hubble_tls_generate
option not configured.Like hubble relay, add conditionals to the volume parts of the hubble-ui deployment template.
c.f. https://github.com/atobaum/kubespray/blob/298f0a05d54df77764a1c257be62bef500f928ac/roles/network_plugin/cilium/templates/hubble/deploy.yml.j2#L64-L105
Which issue(s) this PR fixes:
Fixes #12144
Special notes for your reviewer:
Does this PR introduce a user-facing change?: