Skip to content

fix: do not mount hubble-ui tls volume when cilium_hubble_tls_generate is false #12143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

atobaum
Copy link
Contributor

@atobaum atobaum commented Apr 21, 2025

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fix hubble-ui deployment to not renders tls volume when the cilium_hubble_tls_generate option not configured.

Like hubble relay, add conditionals to the volume parts of the hubble-ui deployment template.
c.f. https://github.com/atobaum/kubespray/blob/298f0a05d54df77764a1c257be62bef500f928ac/roles/network_plugin/cilium/templates/hubble/deploy.yml.j2#L64-L105

Which issue(s) this PR fixes:

Fixes #12144

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix hubble-ui deployment to not renders tls volume when the `cilium_hubble_tls_generate` option not configured.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 21, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @atobaum!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 21, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @atobaum. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@atobaum atobaum closed this Apr 21, 2025
@atobaum atobaum reopened this Apr 21, 2025
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 21, 2025
@yankay
Copy link
Member

yankay commented Apr 25, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 25, 2025
@atobaum
Copy link
Contributor Author

atobaum commented May 2, 2025

Hi @yankay, PR passed the test. Please check PR again. If I have to do something, please tell me. Thank you.

@yankay
Copy link
Member

yankay commented May 6, 2025

Thanks @atobaum
/approve

HI @cyclinder
would you please help to review it.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2025
@atobaum
Copy link
Contributor Author

atobaum commented May 12, 2025

Hi @cyclinder,
Would you be able to review this PR?

Copy link
Contributor

@cyclinder cyclinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed review. the changes looks good.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atobaum, cyclinder, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cyclinder
Copy link
Contributor

@yankay, Please for final approval

@k8s-ci-robot k8s-ci-robot merged commit e1be469 into kubernetes-sigs:master May 12, 2025
46 checks passed
@atobaum atobaum deleted the fix/hubble-tls-config branch May 12, 2025 06:18
@tico88612
Copy link
Member

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not deploy Cilium hubble-ui deployment when cilium_hubble_tls_generate set to false
5 participants