-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Refactor Cilium CNI installation #12101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Cilium CNI installation #12101
Conversation
/ok-to-test |
For the extended cilium test. /label ci-extended |
d5433be
to
775aa12
Compare
/label tide/merge-method-merge |
58e644b
to
c281a50
Compare
/retest-failed |
1 similar comment
/retest-failed |
I didn't review thoroughly yet, I'll see if I can find the time. |
@VannTen Selfishly, I hope it will be released on 2.28 (I'm not sure if Cilium 1.15 is compatible with Kubernetes 1.32), but if it requires a lot of testing (it's too close to the K8s 1.33 release), I agree with your idea. |
I don't have strong opinions on this, and I also don't have a production stake (as our clusters are not on cilium) ; so maybe other more involved in cilium / using it could chime in ?
|
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
When Cilium is configured to replace kube-proxy, it automatically enables dnsProxy, which can conflict with nodelocaldns.
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
19225f2
to
1266527
Compare
/lgtm |
This is the last blocking issue of #12175 (Release proposal of 2.28.0) |
I haven't reviewed the diff in detail, but I don't see anything immediatly wrong and since there has been review by @tmurakam already, let's merge this. Thanks everyone for all the work 🎉 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RaulButuc, tico88612, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@VannTen |
What type of PR is this?
/kind design
/kind feature
What this PR does / why we need it:
We would deprecate the old template installation, and using the Cilium CLI will be better.
Which issue(s) this PR fixes:
Fixes #12049 #12153
Related #11487
Special notes for your reviewer:
Does this PR introduce a user-facing change?: