🐛 (deploy-image/v1alpha1): drop patchStrategy/protobuf tags from Conditions #4893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
camilamacedo86
changed the title
…onditions Simplify the Conditions field in status scaffolding by removing patchStrategy, patchMergeKey, and protobuf tags. Applied to: - deploy-image/alpha-v1 plugin template - Getting Started Memcached example These tags are unnecessary by default and can cause unintended merge behavior. This aligns with best practices for CRD scaffolding.
camilamacedo86
force-pushed
the
fix-confitions
branch
from
3f96e53 to
3b129c2
Compare
k8s-ci-robot
added
size/S
camilamacedo86
changed the title
|
Moving forward, to not block others' follow-up PRs |
camilamacedo86
added
the
lgtm
|
/lgtm For completeness, these markers have no effect on CRDs and only affect core/built-in Kube API types and those built using aggregated API servers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the Conditions field in status scaffolding by removing patchStrategy, patchMergeKey, and protobuf tags.
Applied to:
These fields are unnecessary by default and can introduce unexpected
strategic merge behavior. Omitting them simplifies CRD scaffolding
and avoids compatibility risks for most use cases.
Follows Kubernetes API conventions:
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#typical-status-properties
Motivation