Skip to content

WIP: 🌱 (chore): add grafana plugin test suite #4874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP: 🌱 (chore): add grafana plugin test suite #4874

wants to merge 1 commit into from
+145 −0

Conversation

kersten
Copy link
Contributor

@kersten kersten commented Jun 18, 2025

Add initial test suite and plugin tests for Grafana plugin. Includes tests for plugin initialization, versioning, and scaffolding functionalities.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 18, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kersten
Once this PR has been reviewed and has the lgtm label, please assign camilamacedo86 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @kersten. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 18, 2025
@kersten kersten force-pushed the chore/add-grafana-plugin-test branch from e14920b to 2d7cc92 Compare June 18, 2025 12:38
@kersten kersten marked this pull request as draft June 18, 2025 13:30
@kersten kersten marked this pull request as draft June 18, 2025 13:30
@kersten kersten marked this pull request as draft June 18, 2025 13:30
@kersten kersten marked this pull request as draft June 18, 2025 13:30
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 18, 2025
@kersten kersten changed the title 🌱 (chore): add grafana plugin test suite WIP: 🌱 (chore): add grafana plugin test suite Jun 18, 2025
camilamacedo86
camilamacedo86 reviewed Jun 18, 2025
View reviewed changes
testdata/project-v4-multigroup/go.mod Outdated
@@ -3,7 +3,7 @@ module sigs.k8s.io/kubebuilder/testdata/project-v4-multigroup
go 1.24.0

require (
github.com/cert-manager/cert-manager v1.18.0
github.com/cert-manager/cert-manager v1.18.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase with master?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, will do.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to merge this first? #4875

mateusoliveira43
mateusoliveira43 reviewed Jun 18, 2025
View reviewed changes
pkg/plugins/optional/grafana/v1alpha/plugin_test.go Outdated

var _ = Describe("Grafana Plugin", func() {
var (
plugin *v1alpha.Plugin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about calling this grafanaPlugin and letting "sigs.k8s.io/kubebuilder/v4/pkg/plugin" without plugin2 alias?

@kersten
🌱 (chore): add grafana plugin test suite
bc30540 
Add initial test suite and plugin tests for Grafana plugin.
Includes tests for plugin initialization, versioning, and
scaffolding functionalities.
@kersten kersten force-pushed the chore/add-grafana-plugin-test branch from 2d7cc92 to bc30540 Compare June 19, 2025 05:07
@kersten kersten requested a review from mateusoliveira43 June 19, 2025 05:35
@camilamacedo86
Copy link
Member

Hi @kersten

That is really nice
Would not would like to rebase this one with master
And see if we can get it merged?

@kersten
Copy link
Contributor Author

kersten commented Jul 19, 2025

Hi @camilamacedo86,

I’m on vacation, so please give me some days to respond 😁👌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 left review comments

@Kavinjsir Kavinjsir Awaiting requested review from Kavinjsir

@mateusoliveira43 mateusoliveira43 Awaiting requested review from mateusoliveira43

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kersten @k8s-ci-robot @camilamacedo86 @mateusoliveira43