-
Notifications
You must be signed in to change notification settings - Fork 1.5k
📖 Demo-generate added inside makefile for asciicast #4606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Welcome @Kuzuri247! |
Hi @Kuzuri247. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you a lot for this PR 🥇
See the comments.. but it seems to be in the right direction 🚀
Hi @Kuzuri247
That’s a great point, but it’s not related to the scope of this PR, right? Regarding the Google Code program, we can discuss it in the dedicated discussion thread:
Thanks! 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here will not end up in the current DEMO: (see: https://github.com/kubernetes-sigs/kubebuilder?tab=readme-ov-file#getting-started) been replace for the demo gerated with the script yet.
oould you please address the comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Kuzuri247,
Thank you for your contribution!
Just a few notes:
- The goal is to replace the existing video under the "Getting Started" section with the auto-generated video (see: https://github.com/kubernetes-sigs/kubebuilder?tab=readme-ov-file#getting-started), rather than adding a new "Demo" section.
- Also, the snippet you added —
[](https://asciinema.org/a/YOUR_CAST_ID)
— won’t work without a validYOUR_CAST_ID
, so currently no video will display. - Lastly, could you please squash all your commits into one?
Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Kuzuri247 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #4552