-
Notifications
You must be signed in to change notification settings - Fork 1.6k
WIP 🌱 fix: E2E test for conversion webhook #4475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
WIP 🌱 fix: E2E test for conversion webhook #4475
Conversation
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mateusoliveira43 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @mateusoliveira43. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camilamacedo86 can you check if this change is enough?
after validation, I will apply changes to https://github.com/kubernetes-sigs/kubebuilder/blob/master/hack/docs/internal/multiversion-tutorial/generate_multiversion.go file
"cronjobs.v2.batch.tutorial.kubebuilder.io", "cronjob-sample", | ||
) | ||
_, err = utils.Run(cmd) | ||
Expect(err).NotTo(HaveOccurred(), "Failed to get CronJob v2 resource") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we validate some spec that we are converting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- Makefile: Language not supported
Comments suppressed due to low confidence (1)
docs/book/src/multiversion-tutorial/testdata/project/test/e2e/e2e_test.go:325
- There is a potential race condition if the conversion webhook has not completed processing the CronJob resource. Consider adding a wait or polling mechanism (e.g., using Eventually) before fetching the CronJob v2 resource.
By("fetching CronJob v2 resource")
/ok-to-test |
@mateusoliveira43: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fix #4255