statusoptional: Embed nil check in checkStatusStruct

[mandre]

Return early from the method when statusType is nil, as we can't reliably expect all callers to check for passed arguments before calling the function.

Hopefully fixes #90

[sivchari]

/lgtm

[JoelSpeed]

Change makes sense, but, do you happen to know which API triggered this? Would be good to be able to add a test case to prevent this regressing in the future

[mandre]

Change makes sense, but, do you happen to know which API triggered this? Would be good to be able to add a test case to prevent this regressing in the future

Sorry, I don't. I've seen the error on https://github.com/k-orc/openstack-resource-controller/ main, if you want to take a look. It's unlikely I'll have a chance to add a regression test this week.

[everettraven]

It looks like it is being triggered by

kube-api-linter/pkg/analysis/statusoptional/analyzer.go

Lines 243 to 260 in 6df69a1

	func getStructFromField(pass *analysis.Pass, field *ast.Field) *ast.StructType {
	ident, ok := field.Type.(*ast.Ident)
	if !ok {
	return nil
	}
	typeSpec, ok := utils.LookupTypeSpec(pass, ident)
	if !ok {
	return nil
	}
	structType, ok := typeSpec.Type.(*ast.StructType)
	if !ok {
	return nil
	}
	return structType
	}

returning nil

This is called when checking structs that are inlined:

kube-api-linter/pkg/analysis/statusoptional/analyzer.go

Lines 116 to 117 in 6df69a1

	// Check embedded structs recursively
	a.checkStatusStruct(pass, getStructFromField(pass, childField), markersAccess, jsonTags)

While this change solves the panic, is there an underlying issue here in attempting to grab a struct type from an inlined field?

[yongruilin]

It would be better if you can update the test case for this change.

[JoelSpeed]

While we probably also want to merge this check, the root cause is fixed in #92

[JoelSpeed]

/approve

Lets merge this aswell, even though I think #92 resolved the issue

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment