Add golangci-lint Go plugin version of KAL #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
approved
|
/hold for the moment |
k8s-ci-robot
added
do-not-merge/hold
enxebre
added a commit
to enxebre/hypershift
that referenced
this pull request
May 5, 2025
enxebre
added a commit
to enxebre/hypershift
that referenced
this pull request
May 6, 2025
enxebre
added a commit
to enxebre/hypershift
that referenced
this pull request
May 6, 2025
|
/hold cancel I think we've tested and proven this is working enough |
k8s-ci-robot
removed
the
do-not-merge/hold
sivchari
reviewed
May 7, 2025
JoelSpeed
force-pushed
the
go-plugin
branch
2 times, most recently
from
e5df195 to
6e305c1
Compare
|
/lgtm |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
enxebre
added a commit
to enxebre/hypershift
that referenced
this pull request
May 7, 2025
openshift-merge-bot bot
pushed a commit
to openshift/hypershift
that referenced
this pull request
May 8, 2025
* Introduce kube api linter * Add hack to install kube api linter from vendored code until kubernetes-sigs/kube-api-linter#78 is merged * Downgrade kube api linter to not require go 1.24 * Make kube api linter happy in retro * Run make update
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a version of KAL that can be used with the go plugin system for golangci-lint.
This will be used in K/K to add KAL, currently being tested against this branch in kubernetes/kubernetes#131561
CC @pohly @BenTheElder