Skip to content

Adds nophase linter #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 11, 2024
Merged

Adds nophase linter #5

merged 4 commits into from
Dec 11, 2024

Conversation

theobarberbany
Copy link
Contributor

This PR:

  • Clarifies the explanation around linter configurations and testdata subdirectories, as I found it a bit confusing when first reading.
  • Adds a nophase linter.

@JoelSpeed JoelSpeed mentioned this pull request Dec 6, 2024
Open
27 tasks
@theobarberbany theobarberbany force-pushed the tb/statussubresource branch 5 times, most recently from af7865e to 0c49764 Compare December 6, 2024 15:20
@theobarberbany theobarberbany marked this pull request as ready for review December 6, 2024 15:25
JoelSpeed
JoelSpeed reviewed Dec 6, 2024
View reviewed changes
JoelSpeed
JoelSpeed reviewed Dec 6, 2024
View reviewed changes
@theobarberbany theobarberbany force-pushed the tb/statussubresource branch 2 times, most recently from 27bda5f to 3a7c9c7 Compare December 6, 2024 17:30
@theobarberbany
Update new-linter testing docs
aae8bdc 
Clarify directory structure for testing
@theobarberbany
Nophase linter
63af987 
Initial commit of a nophase linter. Phases, much like capes simply won't
do!

https://i.redd.it/84209d3ydns91.jpg
@theobarberbany
Updates README
f53dcc5 
Adds nophase linter to README.
JoelSpeed
JoelSpeed reviewed Dec 11, 2024
View reviewed changes
JoelSpeed
JoelSpeed reviewed Dec 11, 2024
View reviewed changes
@theobarberbany theobarberbany force-pushed the tb/statussubresource branch 2 times, most recently from 1ca708e to 89b82de Compare December 11, 2024 16:51
JoelSpeed
JoelSpeed previously approved these changes Dec 11, 2024
View reviewed changes
@JoelSpeed JoelSpeed merged commit 9b85836 into kubernetes-sigs:main Dec 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theobarberbany @JoelSpeed