Add linter rule to check for required fields #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelSpeed
force-pushed
the
requiredfields
branch
from
28f0ccb to
ffd8df1
Compare
JoelSpeed
force-pushed
the
requiredfields
branch
from
ffd8df1 to
d5720b5
Compare
JoelSpeed
force-pushed
the
requiredfields
branch
from
d5720b5 to
cfa5797
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a rule that will check that required fields are both not-pointers, but also do not have the
omitemptyjson tag.This linter includes auto-fixing for both of the errors described above.
Since this is core to the API guidelines in Kube, this is enabled by default.