Prevent analyzers from reporting on methods #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelSpeed
force-pushed
the
fix-reporting-on-methods
branch
from
0ec5b5d to
6173f51
Compare
JoelSpeed
force-pushed
the
fix-reporting-on-methods
branch
from
0115764 to
c750a02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A side effect of the refactoring in #11, is that
*ast.Fieldalso accounts for fields in function signatures, so we started getting some false positives.This PR adds a new tests to make sure that linters that would otherwise report on functions, do not.
Reverting some of the refactoring to iterate over structs again, to avoid iterating over function signatures.