-
Notifications
You must be signed in to change notification settings - Fork 288
chore: Consider node.kubernetes.io/not-ready:NoExecute as ephemeral #2265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jigisha620 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @jigisha620. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Pull Request Test Coverage Report for Build 15424771510Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
4d63403
to
9214a4a
Compare
9214a4a
to
62b4219
Compare
Fixes issue in aws-provider - aws/karpenter-provider-aws#8066
Description
When using Kyverno to apply tolerations to the pod, Karpenter was creating two nodeClaims because the node comes up with this taint that gets removed later -
This PR will consider this taint as ephemeral if the node isn't initialized which will prevent karpenter from creating two nodeclaims for the same pod.
How was this change tested?
Added tests. Tested this on my dev cluster.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.