⚠️ Add native SSA support #3253
Conversation
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
This change adds native server-side apply support to the client by extending it with an `Apply` method that takes an `runtime.ApplyConfiguration`.
| @@ -53,6 +54,10 @@ func (c *clientWithFieldValidation) Patch(ctx context.Context, obj Object, patch | |||
| return c.client.Patch(ctx, obj, patch, append([]PatchOption{c.validation}, opts...)...) | |||
| } | |||
|
|
|||
| func (c *clientWithFieldValidation) Apply(ctx context.Context, obj runtime.ApplyConfiguration, opts ...ApplyOption) error { | |||
| return errors.New("Apply is not supported with field validation") | |||
There was a problem hiding this comment.
TODO: It actually is, just not part of the upstream apply options
There was a problem hiding this comment.
Never mind, this doesn't work - SSA will error out if there are unknown fields even when FieldValidation=None is set. What is the best way for us to deal with that in this wrapper, just erroring doesn't seem great.
| @@ -147,6 +148,10 @@ func (n *namespacedClient) Patch(ctx context.Context, obj Object, patch Patch, o | |||
| return n.client.Patch(ctx, obj, patch, opts...) | |||
| } | |||
|
|
|||
| func (n *namespacedClient) Apply(ctx context.Context, obj runtime.ApplyConfiguration, opts ...ApplyOption) error { | |||
| return errors.New("Apply is not supported on namespaced client") | |||
There was a problem hiding this comment.
TODO: Can we make this work? All the ACs should have a SetNamespace, this would be nice to have
There was a problem hiding this comment.
This is actualy pretty difficult, I'd prefer it if we punt on this for now, it can still be done in a follow-up if there is interest.
This reverts commit ad1966a. This doesn't work, the server will always error on additional fields when using SSA, even when fieldValiation=None is configured.
alvaroaleman
added
the
tide/merge-method-squash
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
This change adds native server-side apply support to the client by extending it with an
Applymethod that takes aruntime.ApplyConfiguration.Ref #3183