Skip to content

🌱ci: Update golangci-lint to v2.1.6 and adjust configuration #3187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dongjiang1989
Copy link
Contributor

@dongjiang1989 dongjiang1989 commented Apr 2, 2025

This updates golangci-lint to v2.1.6 with the associated configuration in workflows and Makefile

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 2, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 2, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @dongjiang1989. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 2, 2025
@sbueringer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 4, 2025
@sbueringer
Copy link
Member

/retest

@dongjiang1989
Copy link
Contributor Author

/test pull-controller-runtime-test

@dongjiang1989
Copy link
Contributor Author

Thanks @sbueringer
Fixed unittest case fail. Please re-check it

@dongjiang1989 dongjiang1989 force-pushed the update-golangci-lint-v2 branch from 3a5ab0a to 6c69d61 Compare April 14, 2025 09:15
@dongjiang1989
Copy link
Contributor Author

/test pull-controller-runtime-test

@sbueringer
Copy link
Member

/assign

Signed-off-by: dongjiang <dongjiang1989@126.com>
@dongjiang1989 dongjiang1989 force-pushed the update-golangci-lint-v2 branch from 8a37d41 to 9c38211 Compare May 14, 2025 10:01
@dongjiang1989 dongjiang1989 changed the title 🌱ci: Update golangci-lint to v2.0.2 and adjust configuration 🌱ci: Update golangci-lint to v2.1.6 and adjust configuration May 14, 2025
@dongjiang1989
Copy link
Contributor Author

Thanks @sbueringer
Please re-check it

@sbueringer
Copy link
Member

Thank you very much!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 193465e87bec7a5d20023b13a2cfdc54a16c1bf9

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dongjiang1989, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit d9a2274 into kubernetes-sigs:main May 14, 2025
14 checks passed
@dongjiang1989 dongjiang1989 deleted the update-golangci-lint-v2 branch May 15, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants