🌱 adding SubjectAccessReview.authorization.k8s.io/v1 webhook support

[everpeace]

This PR is the second try which adds SubjectAccessReview.authorization.k8s.io/v1 webhook support. The original PR is #1535 posted by @rfranzke, which is closed by stale long time ago.

After the long time, I'm now interested in this feature(#1535 (comment)). Thus, this PR is based on #1535 and added some cleanups and migrations on the top of it.

cc/ @rfranzke @alvaroaleman @christopherhein @vincepri @estroz

Note: I would like to use this feature in implementing karmada-io/karmada#4593

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: everpeace
Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[everpeace]

/remove-lifecycle stale

[alvaroaleman]

Hi, thanks for this PR. Controller-Runtime is a library for building controllers, so an authorization webhook does IMHO not really fit into it.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[everpeace]

/close

[k8s-ci-robot]

@everpeace: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[rfranzke]

Hi, thanks for this PR. Controller-Runtime is a library for building controllers, so an authorization webhook does IMHO not really fit into it.

I somehow missed this comment, but thanks to @everpeace's activity, I now saw it. With this line of thought, why there is support for authn webhooks then? Shouldn't this be deprecated and removed accordingly?

[sbueringer]

It's always a lot harder to drop something and break existing users compared to not adding something